New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DONE] fix lookup problems with TimeSeriesSubsetArrayField #210

Merged

jpprins1 merged 3 commits into master from TimeSeriesSubsetArrayField_remove_lookup

Dec 21, 2023

Contributor

jpprins1 commented Dec 15, 2023 •

edited

Loading

Remove unnecessary ordering by lookup_index. subset_index already takes care of that.

Todo:

unit-test(?) -> need a gridadmin.h5 and results3d.nc that can be included in this repo and have boundaries.

jpprins1 added 3 commits

December 15, 2023 15:59


          fix lookup problems with TimeSeriesSubsetArrayField

428f127


          added test for model with boundaries

d49a8bd


          Added note about broken breaches object

067c32e

jpprins1 merged commit bd0dd4b into master

7 checks passed

jpprins1 deleted the TimeSeriesSubsetArrayField_remove_lookup branch

December 21, 2023 12:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet